Fix: Topics module of V7.9.0.3.2e, sql syntax error

Nuke Soldier Joined: Jan 17, 2006 Posts: 12

I found a bug in the Topics module with MySQL5. It didnt show the topics.
Reason was the mysql5 keyword "reads", used as varname in the query.
By that, the query failed and returned 0 rows, so no topics were shown.

Fix:
(line numbers are from PHPNuke7.9.0.3.2e)

---
OPEN FILE: modules/Topics/index.php

FIND: (line 28)

Code:

$sql = "SELECT t.topicid, t.topicimage, t.topictext, count(s.sid) AS stories, SUM(s.counter) AS reads FROM ".$prefix."_topics t LEFT JOIN ".$prefix."_stories s ON (s.topic = t.topicid) GROUP BY t.topicid, t.topicimage, t.topictext ORDER BY t.topictext";

REPLACE WITH:

Code:

$sql = "SELECT t.topicid, t.topicimage, t.topictext, count(s.sid) AS stories, SUM(s.counter) AS thereads FROM ".$prefix."_topics t LEFT JOIN ".$prefix."_stories s ON (s.topic = t.topicid) GROUP BY t.topicid, t.topicimage, t.topictext ORDER BY t.topictext";

FIND: (line 55)

Code:

$output .= "<big>·</big> "._TOTREADS.": ".(isset($row['reads']) ? $row['reads'] : 0)."";

REPLACE WITH:

Code:

$output .= "<big>·</big> "._TOTREADS.": ".(isset($row['thereads']) ? $row['thereads'] : 0)."";

SAVE FILE: modules/Topics/index.php
DONE
---

Nuke Cadet Joined: Dec 09, 2008 Posts: 1

Maybe it is a bit to late to answer a 2 years old message, but I gice it a chance. Your bux fix did help me with my php 8.0, but there is still some problems with the topics module.

When you click on the topic icon, you are supposed to come to a site with just this topic. However, you come to the news site, with all topics in same order as on first side.

If you clikc the topic icon in news module, you come to an empty site with just a search box.

I think this is a bug on news/index.php. It doesnät take the link OK. I i use the link <a....&topic=$topicid>, I come to the news side with all topics on. If I use the link <a ........&new_topic=$topicid> I comer to the empty side with search box.

Do you have any clue what is wrong. I think the new_topic link is more correct then the other, but the site can not find the topic.

I hope you will answer this.

regards,

Markus Holst
Sweden